Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SLSA/SEC-973): container image signing action #65

Merged
merged 4 commits into from
Oct 17, 2023
Merged

feat(SLSA/SEC-973): container image signing action #65

merged 4 commits into from
Oct 17, 2023

Conversation

saisatishkarra
Copy link
Collaborator

No description provided.

@saisatishkarra
feat(slsa/image-sign): Keyless image signing using Cosign
26417d6 
filter uniq registry and sign using digest

Always recursively sign manifest digests if present
@saisatishkarra
update readme for sign action
f8f7bd4
@saisatishkarra
fix readme
9821848 
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
@saisatishkarra saisatishkarra marked this pull request as ready for review October 17, 2023 14:32
@saisatishkarra saisatishkarra requested review from a team as code owners October 17, 2023 14:32
@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited
Loading

Luacheck Report

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
4 tests ±0  4 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
8 runs  ±0  8 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 23189c8. ± Comparison against base commit c03e30a.

♻️ This comment has been updated with latest results.

@saisatishkarra
enable signing transaprency by default
23189c8 
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
@saisatishkarra
Copy link
Collaborator Author

saisatishkarra commented Oct 17, 2023 •
edited
Loading

Added docker push user and token secrets to the repository to run the job only in the context of approved PR / kong org.

devonl-kong
devonl-kong approved these changes Oct 17, 2023
View reviewed changes
Copy link

@devonl-kong devonl-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible to me

@saisatishkarra saisatishkarra merged commit b7def0b into main Oct 17, 2023
10 checks passed
@saisatishkarra saisatishkarra deleted the feat/image-signing branch October 17, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devonl-kong devonl-kong devonl-kong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saisatishkarra @devonl-kong