Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cache argument in docs #2195

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Update cache argument in docs #2195

merged 2 commits into from
Jul 3, 2024

Conversation

OmeGak
Copy link
Contributor

@OmeGak OmeGak commented Jun 27, 2024

The image_cache option specified in the documentation is not correct. The correct option is cache. Using image_cache leads to no cache being applied at all, as the option is completely ignored without warning. It would be useful to fail when passing invalid options, to avoid them silently not being applied.

@liZe
Copy link
Member

liZe commented Jun 27, 2024

The image_cache option specified in the documentation is not correct.

Thank you!

It would be useful to fail when passing invalid options, to avoid them silently not being applied.

Yes, it would be useful. Comparing the options keys to the ones in DEFAULT_OPTIONS in render should work.

@liZe liZe added the documentation Problems or improvements needed on the documentation or on the website label Jun 27, 2024
@liZe liZe added this to the 63.0 milestone Jun 27, 2024
@liZe
Copy link
Member

liZe commented Jul 3, 2024

Thanks!

@liZe liZe merged commit e5fa17e into Kozea:main Jul 3, 2024
6 checks passed
@OmeGak
Copy link
Contributor Author

OmeGak commented Jul 3, 2024

It was my pleasure! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Problems or improvements needed on the documentation or on the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants