Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PFEM-Fluid] new cut-PFEM element and settings #969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AFranci
Copy link
Member

@AFranci AFranci commented Mar 7, 2024

This PR introduces the cut-PFEM element among the options to chose. The order and name of elements appearing in the interface has been also changed. Finally, penalty_coefficient now appears as an input parameter of the solver.

@AFranci
Copy link
Member Author

AFranci commented Mar 7, 2024

Hi Javi!
Please, check this PR and tell me if you notice something to change. Sometimes when I open more times the options of the elements I get this error/warning

image

I am not sure that depends on the changes I am doing in this PR.

@AFranci
Copy link
Member Author

AFranci commented Mar 7, 2024

Furthermore, I would like to add a new change but I may need your help.
When the user has selected TwoStepUpdatedLagrangianVPFluidCutFemElement2D or TwoStepUpdatedLagrangianVPFluidCutFemElement3D in the interface, I would like to have automatically the following in the ProjectParameters.json:

"meshing_domains" : [{
"model_part_name" : "Body1",
"python_module" : "fluid_meshing_domain",
"alpha_shape" : 1.3,
"meshing_strategy" : {
"python_module" : "cut_pfem_fluid_meshing_strategy",
"remesh" : true,
"refine" : true,
"transfer" : false,
"reference_element_type" : "TwoStepUpdatedLagrangianVPFluidCutFemElement3D",
"reference_condition_type" : "CompositeCondition3D3N"
}

Instead of

"meshing_domains" : [{
"model_part_name" : "Body1",
"python_module" : "fluid_meshing_domain",
"alpha_shape" : 1.3,
"meshing_strategy" : {
"python_module" : "fluid_meshing_strategy",
"remesh" : true,
"refine" : true,
"transfer" : false,
"reference_element_type" : "TwoStepUpdatedLagrangianVPFluidElement3D",
"reference_condition_type" : "CompositeCondition2D2N"
},

Do you think it is possible?

Thank you for your help!

@jginternational
Copy link
Member

Hi @AFranci

The first part, if you have tested it and works, it's fine.

For the second query, I could not reproduce it, so send me more information if it's still a problem

For the third query, as you can see in kratos.gid\apps\PfemFluid\write\writeProjectParameters.tcl Line 299:304:307 the reference_element_type is set by tcl, so the answer is YES, it is possible to change it, BUT:

  • It seem to be a loop over Bodies, and a body can contain a lot of parts, and each part be different.
    We can ask for all the elements applied to the body, and if there's at least one cut element, set the new value.

But I don't know if that is the expected behaviour

@jginternational
Copy link
Member

@AFranci what is the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants