Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add POPC op code before return in try statement without finally clause. #305

Closed
Kray-G opened this issue Jul 19, 2021 · 0 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Kray-G
Copy link
Owner

Kray-G commented Jul 19, 2021

try {
    return something();
} catch (e) {
    error();
}

There is no output of POPC when using return statement with expression in try statement without finally clause.
This may cause a crash by accessing invalid stack field when exception occurs.

@Kray-G Kray-G added the bug Something isn't working label Jul 19, 2021
@Kray-G Kray-G added this to the v1.1.0 milestone Jul 19, 2021
@Kray-G Kray-G self-assigned this Jul 19, 2021
Kray-G added a commit that referenced this issue Jul 19, 2021
@Kray-G Kray-G closed this as completed in cb1e754 Jul 19, 2021
Kray-G added a commit that referenced this issue Jul 21, 2021
Kray-G added a commit that referenced this issue Jul 26, 2021
fixes #305: modifed the fix location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant