Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] Adding channels input for bundle images in release workflow #138

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

didierofrivia
Copy link
Contributor

This PR is part of Kuadrant Operator issue Kuadrant/kuadrant-operator#244

The workflow dispatch input channels accepts comma separated values, i.e.: "stable,release". The Makefile target could be executed as:

make prepare-release \
  VERSION=0.7.0 \
  AUTHORINO_VERSION=0.14.0 \
  CHANNELS=stable,release

And it will generate, among other changes, the following:

diff --git a/bundle.Dockerfile b/bundle.Dockerfile
index 8fe9a64..5b9211f 100644
--- a/bundle.Dockerfile
+++ b/bundle.Dockerfile
@@ -5,7 +5,7 @@ LABEL operators.operatorframework.io.bundle.mediatype.v1=registry+v1
-LABEL operators.operatorframework.io.bundle.channels.v1=alpha
+LABEL operators.operatorframework.io.bundle.channels.v1=stable,release

diff --git a/bundle/metadata/annotations.yaml b/bundle/metadata/annotations.yaml
index 118a56d..39e6d57 100644
--- a/bundle/metadata/annotations.yaml
+++ b/bundle/metadata/annotations.yaml
@@ -4,7 +4,7 @@ annotations:
-  operators.operatorframework.io.bundle.channels.v1: alpha
+  operators.operatorframework.io.bundle.channels.v1: stable,release

Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, results in the bundle labels being updated with the value of CHANNELS. In this case as the catalog is sqlite-based the channels are set from the bundle labels.

@didierofrivia didierofrivia merged commit f4bc35c into main Sep 11, 2023
7 checks passed
@didierofrivia didierofrivia deleted the workflow-channels-in-bundle branch September 11, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants