Support local cert manager #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
previously approved these changes
Sep 28, 2023
Makefile
Outdated
| @@ -182,7 +185,7 @@ docker-push: ## Push docker image with the manager. | |||
|
|
|||
| ##@ Deployment | |||
|
|
|||
| install: manifests kustomize install-authorino ## Install CRDs into the K8s cluster specified in ~/.kube/config. | |||
| install: manifests kustomize install-cert-manager install-authorino ## Install CRDs into the K8s cluster specified in ~/.kube/config. | |||
There was a problem hiding this comment.
Technically, cert-manager is a dependency for the Authorino webhook, which is deployed by install-authorino. I'd move it there, instead of make install.
There was a problem hiding this comment.
Sure I am not going to argue with that.
Add the installation of the cert manager for the tools used during dev work.
Boomatang
force-pushed
the
local-setup-cert-manager
branch
from
61fa39d
to
a133c2b
Compare
Codecov Report
@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 63.11% 64.48% +1.36%
==========================================
Files 1 1
Lines 732 732
==========================================
+ Hits 462 472 +10
+ Misses 220 211 -9
+ Partials 50 49 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the installation of the cert manager for the tools used during dev work.
Validation
Closes: Kuadrant/kuadrant-operator#257