Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce AuthConfig v1beta3 #493

Merged
merged 5 commits into from
Oct 16, 2024
Merged

feat: introduce AuthConfig v1beta3 #493

merged 5 commits into from
Oct 16, 2024

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Oct 1, 2024

Description

Closes: #480

Introduces AuthConfig v1beta3 and uses it as the storaged version in preparation for upcoming api changes. Currently it is straight copy of v1beta2, so removes the need of the conversion webhook. v1beta1 has been completely removed and docs have been updated to reference v1beta3

TODOs

  • Remove deloying authorino-operator webhook
    • This would be done in authorino operator
  • v1beta3 as default AuthConfig version in makefile?
  • v1beta3 as the storage version?
  • v1beta3 as api version used in code?
  • docs to use v1beta3 & remove v1beta1 references

Signed-off-by: KevFan <chfan@redhat.com>
Copy link

gitguardian bot commented Oct 1, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8184017 Triggered Keycloak Api Keys ebe9c80 tests/v1beta3/authconfig.yaml View secret
8184017 Triggered Keycloak Api Keys ebe9c80 tests/v1beta1/authconfig.yaml View secret
8184017 Triggered Keycloak Api Keys ebe9c80 tests/v1beta1/authconfig.yaml View secret
8184017 Triggered Keycloak Api Keys ebe9c80 tests/v1beta1/authconfig.yaml View secret
8184017 Triggered Keycloak Api Keys ebe9c80 tests/v1beta3/authconfig.yaml View secret
8184017 Triggered Keycloak Api Keys ebe9c80 tests/v1beta3/authconfig.yaml View secret
8184018 Triggered Elliptic Curve Private Key ebe9c80 tests/v1beta3/authconfig.yaml View secret
8184018 Triggered Elliptic Curve Private Key ebe9c80 tests/v1beta1/authconfig.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Signed-off-by: KevFan <chfan@redhat.com>
@KevFan KevFan changed the title feat: introduce v1beta3 feat: introduce AuthConfig v1beta3 Oct 1, 2024
Signed-off-by: KevFan <chfan@redhat.com>
@KevFan
Copy link
Contributor Author

KevFan commented Oct 2, 2024

@guicassolato I forget what we decided, do we want v1beta3 as the stored version immediately and move the code to depend on these types given that it's a straight copy of v1beta2 at the moment? 🤔

@guicassolato
Copy link
Collaborator

@guicassolato I forget what we decided, do we want v1beta3 as the stored version immediately and move the code to depend on these types given that it's a straight copy of v1beta2 at the moment? 🤔

I think so, @KevFan. Since the last released version of Authorino already made v1beta2 the stored version, users can count on a migration path all the way from v1beta1 (deprecated) to latest v1beta3 (about to become the stored version in the next release).

Signed-off-by: KevFan <chfan@redhat.com>
Signed-off-by: KevFan <chfan@redhat.com>
@KevFan
Copy link
Contributor Author

KevFan commented Oct 10, 2024

@KevFan KevFan marked this pull request as ready for review October 10, 2024 14:54
@KevFan KevFan merged commit c02c565 into main Oct 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AuthConfig v1beta3
2 participants