REMOVE: kuadrant controller management of limitador #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boomatang
force-pushed
the
sotw/REMOVE/kuadrant-controller/limitador
branch
2 times, most recently
from
784517a
to
b4b0cbd
Compare
Boomatang
force-pushed
the
sotw/REMOVE/kuadrant-controller/limitador
branch
from
b4b0cbd
to
f97af77
Compare
With the move to the state of the world reconcile the kuadrant controller no longer needs to reconcile the creation of the limitador resource. Signed-off-by: Jim Fitzpatrick <jfitzpat@redhat.com>
Boomatang
force-pushed
the
sotw/REMOVE/kuadrant-controller/limitador
branch
from
f97af77
to
b593a77
Compare
The status reconcile needs to watch the resources for chances. Signed-off-by: Jim Fitzpatrick <jfitzpat@redhat.com>
|
@KevFan So you are aware I need to add back in the watches for the limitador and authorino as these are need to trigger the status update in kuadrant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to the state of the world reconcile the kuadrant controller no longer needs to reconcile the creation of the limitador resource.
This change is independent but will introduce a breaking change if merged before #883 and #887
Required PRs: