-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: immediate limits sync to pod via annotation #127
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 68.19% 68.34% +0.14%
==========================================
Files 16 16
Lines 1154 1191 +37
==========================================
+ Hits 787 814 +27
- Misses 325 334 +9
- Partials 42 43 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
48db34f
to
15ca71f
Compare
15ca71f
to
827692e
Compare
61ea8eb
to
2ead948
Compare
Verification steps working like a charm nice that the steps create two replicas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments and one "bigger" one I would like to discuss pros and cons.
… Gomega for assertions in Evenutally functions
1e12524
to
f0b39d5
Compare
Resolved comments and rebased with main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and the verification steps work with the resource version of the configmap
Description
Part of Kuadrant/kuadrant-operator#414
This PR adds a feature to annotate Limitador pods with the limits config map resource version. This change ensures that modifications to the limits will promptly trigger a reload or synchronization of the limit configuration to Limitador pods. Consequently, it ensures that pod limits are always immediately up to date.
This enhancement will enable us to utilize the Limitador CR
Ready
condition as a way of naively assuming that limits are enforced.Other additions include
Verification
The following have already been verified in the included integration test but if you want to verify manually: