Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignore
max_value
as per #87 … but since we use the same (de)serialization mechanism for data coming in (limits file) and data going out (to the counter storage), this comes with a sad side effect:You can leave the
max_value
out of your limits file and it will default to0
which is probably not what one would ever want. I could still validate that when loading limits from the file, they have a non-negative value as a separate validation… but with this change, at least if someone misspellsmax_value
(e.g.maxvalue
, which happened to me), the parsing will fail with a good explanation.