Prepping v1.0.0-rc1 (crate v0.3.0-rc1) release #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤣 Interesting egg or chicken problem |
|
|
eguzki
reviewed
Oct 19, 2022
| @@ -16,7 +16,7 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: limitador | |||
| image: quay.io/3scale/limitador:0.5.1 | |||
There was a problem hiding this comment.
there is way to break the egg-chicken issue.
- In this deployment object, we make reference to not-existing image, for example:
limitador:dev - Build the image of the current workspace and tag it as
limitador:dev. - Before creating the deployment object in kind, load the image
kind load docker-image limitador:dev --name ${cluster-name}
- Create the deployment object. The image being deployed will be the one recently built.
Maybe not for this PR
eguzki
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.