🔥 Sled and use RocksDB instead #170
Conversation
alexsnaps
force-pushed
the
rocksdb
branch
3 times, most recently
from
202aef7
to
4da5823
Compare
alexsnaps
force-pushed
the
rocksdb
branch
5 times, most recently
from
7816767
to
9a9742c
Compare
alexsnaps
changed the title
It does, thanks for that |
|
Looking good. I would go ahead and try to add the |
|
Have you considered using the Compaction Filter to implement the TTL?? |
| @@ -8,7 +8,7 @@ ENV CARGO_NET_GIT_FETCH_WITH_CLI=true | |||
| ARG RUSTC_VERSION=1.67.1 | |||
| RUN apk update \ | |||
| && apk upgrade \ | |||
| && apk add build-base binutils-gold openssl3-dev protoc protobuf-dev curl git \ | |||
| && apk add build-base binutils-gold openssl3-dev protoc protobuf-dev curl git linux-headers clang \ | |||
There was a problem hiding this comment.
there may be issues with the new ubi8 based images #168
I do when disk optimized: https://github.com/Kuadrant/limitador/pull/170/files#diff-b41633d05540bf2734d97b29f9dab57f411c275100114fa933f6b0582cd04abaR124-R135 But it only will expire when compacting, this is ignored on reads... so you still need to deal with expired value on read, just less of them, depending whether they come from a segment that was compacted (I don't recall if the memtable get compacted when written to disk) |
|
Closed in favor of #178 |
This builds on and supersedes both #146 & #167 … It replaces sled as the underlying storage for local persistence with RocksDB using the Rust bindings… which both were extensively battle tested.
If we think this is indeed a better choice, it'd probably be worthwhile
git rebase -ifrom HEAD of main, squashing all the work from the other PRs… I kept them as is for now, hoping this makes reviewing somewhat easier.