Bench: Actually create different limits for each scenario #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is going to hurt:
We always created the bench "wrong", or rather we created dups of one identical
Limit
in each namespace, when it was more than1
(i.e.10
&50
). Sadly this meant that Limitador would only ever do one limit (with more variables and conditions tho)... So this fixes that, and as such exposes theO(n)
problem I mentioned in our refinement call...Bench result, compared as to when it was 1 limit, whereas this now are 10 limits to be tested against:
10 namespaces with 10 limits each with 10 conditions and 10 variables
In memory:
On disk:
With Redis:
As expected, Memory is the worst:
O(n)
, while Redis, which does anMGET
is the least impacted. While the operation is stillO(n)
within Redis, the network overhead ans (de)serialization dominates the latency here…