Cached delta updates #316
Merged
Cached delta updates #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
alexsnaps
force-pushed
the
cached_delta_updates
branch
from
78b1a2b
to
5a3a2a0
Compare
| @@ -292,43 +292,48 @@ impl CachedRedisStorageBuilder { | |||
| async fn update_counters<C: ConnectionLike>( | |||
| redis_conn: &mut C, | |||
| counters_and_deltas: HashMap<Counter, Arc<CachedCounterValue>>, | |||
| ) -> Result<Vec<(Counter, i64, i64)>, StorageErr> { | |||
| ) -> Result<Vec<(Counter, i64, i64, i64)>, StorageErr> { | |||
There was a problem hiding this comment.
the new value corresponds to the delta in the last position? maybe we could add an doc annotation to this fn
There was a problem hiding this comment.
I'll burn the whole ttl stuff, use absolute timestamps instead and then refactor this...
I hate tuples... of 4 elements even more so.
| let (_, val, delta, ttl) = &mut res[i]; | ||
| *val = script_res[j]; | ||
| *delta = script_res[j] - *delta; | ||
| *ttl = script_res[j + 1]; |
There was a problem hiding this comment.
Ok, so last one is ttl
| "req.method == \"GET\"", | ||
| c.limit().conditions().iter().collect::<Vec<_>>()[0] | ||
| NEW_VALUE_FROM_REDIS - INITIAL_VALUE_FROM_REDIS - LOCAL_INCREMENTS, | ||
| remote_increments |
There was a problem hiding this comment.
explicit, so we can make assertions with the redis deltas 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on #315 to be reviewed and merged