Ttl expiry #334
Merged
Ttl expiry #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
force-pushed
the
ttl_expiry
branch
8 times, most recently
from
00feb30
to
dbd7f43
Compare
| @@ -68,8 +68,8 @@ impl Counter { | |||
| false | |||
| } | |||
|
|
|||
| pub fn seconds(&self) -> u64 { | |||
| self.limit.seconds() | |||
| pub fn window(&self) -> Duration { | |||
There was a problem hiding this comment.
This is great, it was always too ambiguous to refer to seconds
|
Looking good, still some conflicts with |
Still...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329
Also cleans up some
featurestuff, tho tests rely on some async runtime, so thatcargo test --no-default-featureswon't compile :(