Add some load testing tools to the sandbox #351

chirino · 2024-06-04T14:00:36Z

Documents how to use ghz to benchmark the gRPC interface, and adds a rust goose based load test that works against the envoy proxy which should help simulate more real world end-to-end stats.

Adds a deployment option for the distributed store.

Note: this PR stacks on PR #350 so that we can easily build a local container using docker-compose with the right feature enabled depending on the deployment.

limitador-server/sandbox/docker-compose-limitador-memory.yaml

limitador-server/sandbox/docker-compose-limitador-distributed.yaml

limitador-server/sandbox/README.md

eguzki · 2024-06-05T07:56:48Z

limitador-server/sandbox/docker-compose-limitador-distributed.yaml

+      args:
+        - CARGO_ARGS=--all-features
+    depends_on:
+      - envoy


envoy is not being used, is it?

All the other limitador compose files have this dependency. But Yeah that seems backwards.

yeah, exactly.

We are pushing the current "unique" sandbox too far. In other PR, we could refactor to have different sandboxes, each one running only necessary services. Each sandbox with custom readme.md and docker-compose.yaml file.

I fixed the dependency on this compose file and the other ones too.

eguzki · 2024-06-05T07:58:00Z

Note: this PR stacks on PR #350 so that we can easily build a local container using docker-compose with the right feature enabled depending on the deployment.

I would not make this PR depend on #350 . We might want to merge this and not the other one.

chirino · 2024-06-05T11:52:07Z

I would not make this PR depend on #350 . We might want to merge this and not the other one.

Can't build the docker image with the --all-features flag on a mac without #350.

alexsnaps · 2024-06-05T14:35:42Z

I'm somewhat confused about this pull request tbh... I'm probably missing something, but what's the intent here?

alexsnaps · 2024-06-05T14:37:28Z

Just to be clear tho... not against it, just missing how/when I'd use this

alexsnaps · 2024-06-05T14:39:19Z

Cargo.toml

@@ -1,5 +1,5 @@
 [workspace]
-members = ["limitador", "limitador-server"]
+members = ["limitador", "limitador-server", "limitador-server/sandbox/loadtest"]


I wouldn't add this to the workspace here... There is no dependency and loadtest is really not useful in the context of limitador work, yet that'd impose build times et al...

makes sense, removed it.

* support passing cargo build args to the Docker image builder, allowing us to enable all features. * add a distributed deployment option in the sandbox * update the deployments to have envoy depend on limitador instead of limitador depending on envoy. Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>

chirino · 2024-06-07T17:06:58Z

squashed and removed #350

chirino · 2024-06-07T17:13:08Z

limitador-server/sandbox/README.md

+```
+
+The report will be saved in `report.htm` file.
+


@alexsnaps see above re: how to use

Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>

chirino · 2024-06-07T17:24:36Z

@eguzki 3 node deployment option added.

eguzki · 2024-06-10T08:56:06Z

limitador-server/sandbox/README.md

+
+The `make deploy-distributed` target can be connected to other Limitador servers but requires you to set the `PEER_ID` and `PEER_URLS` environment variables when you run the target.
+
+If you have 3 servers you want to replicate between, you would run the following commands:


no need to have 3 servers, right?

Well, you might still want to do this on 3 machines if you are benchmarking. Doing it all on one would not be very representative.

eguzki

Looking good.

left few comments.

After this PR is being merged, I probably will refactor a bit to have multiple "sandboxes" instead a "big" one. More scalable (easier to add new ones).

eguzki · 2024-06-10T16:02:19Z

Dockerfile

@@ -4,20 +4,34 @@

 # Use bullseye as build image instead of Bookworm as ubi9 does not not have GLIBCXX_3.4.30
 # https://access.redhat.com/solutions/6969351
-FROM --platform=${BUILDPLATFORM} rust:1.78.0-bullseye as limitador-build


is this breaking cross platform builds?

why would it? This Dockerfile works fine on my arm mac.

https://docs.docker.com/reference/dockerfile/#from

The optional --platform flag can be used to specify the platform of the image in case FROM references a multi-platform image. For example, linux/amd64, linux/arm64, or windows/amd64. By default, the target platform of the build request is used. Global build arguments can be used in the value of this flag, for example [automatic platform ARGs](https://docs.docker.com/reference/dockerfile/#automatic-platform-args-in-the-global-scope) allow you to force a stage to native build platform (--platform=$BUILDPLATFORM), and use it to cross-compile to the target platform inside the stage.

When I need to do cross-compile, I need that rust:1.78.0-bullseye be native to my current machine platform. When docker buildx build --platform=linux/amd64, without that FROM --platform=${BUILDPLATFORM} the rust:1.78.0-bullseye will be linux/amd64 and my current machine platform might be something else (like arm). Which is not correct.

I think it's best if the plain Dockerfile just does a container build that matches the host, and then we have additional Dockerfiles to do the cross compiles like Dockerfile.aarch64.

Your saying your on arm trying to build linux/amd64 with that Dockerfile?? Shouldn't that work if the host is running QEMU?

Dockerfile

…er, we don’t build it. Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>

eguzki · 2024-06-12T20:31:48Z

Dockerfile

+COPY limitador/Cargo.toml ./limitador/
+COPY limitador-server/Cargo.toml ./limitador-server/
+RUN mkdir -p limitador-server/src && echo 'fn main() {}' > limitador-server/src/main.rs
+RUN mkdir -p limitador-server/sandbox/loadtest/src && echo 'fn main() {}' > limitador-server/sandbox/loadtest/src/main.rs


is this still needed?

yep that's not needed either..

Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>

chirino force-pushed the sandbox-distributed branch from 19bd3c5 to 6387293 Compare June 4, 2024 14:04

eguzki reviewed Jun 5, 2024

View reviewed changes

alexsnaps reviewed Jun 5, 2024

View reviewed changes

chirino force-pushed the sandbox-distributed branch from 046b81c to 9b3f8bd Compare June 7, 2024 17:00

chirino force-pushed the sandbox-distributed branch from 9b3f8bd to 54136f4 Compare June 7, 2024 17:06

chirino commented Jun 7, 2024

View reviewed changes

limitador-server/sandbox/README.md

```

The report will be saved in `report.htm` file.

Copy link

Contributor Author

chirino Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexsnaps see above re: how to use

Add support for a 3 node distributed deployment.

d6d7b37

Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>

chirino marked this pull request as ready for review June 7, 2024 17:33

eguzki reviewed Jun 10, 2024

View reviewed changes

No need to copy the loadtest cargo file into the Docker build contain…

2c1dbc2

…er, we don’t build it. Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>

alexsnaps approved these changes Jun 12, 2024

View reviewed changes

eguzki requested changes Jun 12, 2024

View reviewed changes

Dropping more loadtest related bit from the Dockerfile.

d4ee1f6

Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>

chirino merged commit d44ebdb into Kuadrant:main Jun 13, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add some load testing tools to the sandbox #351

Add some load testing tools to the sandbox #351

chirino commented Jun 4, 2024 •

edited

Loading

eguzki Jun 5, 2024

chirino Jun 5, 2024

eguzki Jun 5, 2024

chirino Jun 7, 2024

eguzki commented Jun 5, 2024

chirino commented Jun 5, 2024

alexsnaps commented Jun 5, 2024

alexsnaps commented Jun 5, 2024

alexsnaps Jun 5, 2024

chirino Jun 7, 2024

chirino commented Jun 7, 2024

chirino Jun 7, 2024

chirino commented Jun 7, 2024

eguzki Jun 10, 2024

chirino Jun 10, 2024

eguzki Jun 10, 2024

eguzki left a comment

eguzki Jun 10, 2024

chirino Jun 12, 2024

eguzki Jun 12, 2024 •

edited

Loading

chirino Jun 12, 2024 •

edited

Loading

eguzki Jun 12, 2024

chirino Jun 12, 2024


		The `make deploy-distributed` target can be connected to other Limitador servers but requires you to set the `PEER_ID` and `PEER_URLS` environment variables when you run the target.

		If you have 3 servers you want to replicate between, you would run the following commands:

Add some load testing tools to the sandbox #351

Add some load testing tools to the sandbox #351

Conversation

chirino commented Jun 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eguzki commented Jun 5, 2024

chirino commented Jun 5, 2024

alexsnaps commented Jun 5, 2024

alexsnaps commented Jun 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chirino commented Jun 7, 2024

Choose a reason for hiding this comment

chirino commented Jun 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eguzki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eguzki Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

chirino Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chirino commented Jun 4, 2024 •

edited

Loading

eguzki Jun 12, 2024 •

edited

Loading

chirino Jun 12, 2024 •

edited

Loading