Impl From<&str> for Namespace instead of FromStr as it can't fail
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
changed the title
From<&str> for Namespace instead of FromStr as it can't fail
rahulanand16nov
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NamespaceimplementsFromStrfrom the stdlib. But afaictNamespaceis aString, as such anyStringrepresents a validNamespace.FromStrcan fail tho. Even if our implementation hadtype Err = core::convert::Infallibleit still means you have to callunwrap()on theResultfrom the thetry_into()call.There might have been a reason for this, but given the existing infallible
From<String>implementation, I can't see it.This changes this to
impl From<&str> for Namespace, just as it already did forFrom<String>and makes the.into() -> Namespaceremoving the intermediaryResultthat was always a success anyways. As such it removes a bunch of.unwrap()from the code base.Part one of more to come...