Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring for external auth. Vol I #64

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Refactoring for external auth. Vol I #64

merged 2 commits into from
Aug 13, 2024

Conversation

didierofrivia
Copy link
Contributor

@didierofrivia didierofrivia commented Aug 7, 2024 •
edited
Loading

Part of the work needed for #58

This PR is the first of hopefully not too many that aims to re-arrange and open the code in order to implement External Auth.

Notes:

  • Renames RateLimitPolicy struct to Policy
  • Keeps config with rateLimitPolicies field, but renames it to policies field within the struct PluginConfiguration when deserializing.
  • Delegates the building of descriptors to the Policy instead of Filter
  • Missing configuration change, TODO alongside a PR to Kuadrant Operator. Its still functional since it's serde::renaming the field

@didierofrivia
[refactor] Renaming RateLimitPolicy to Policy
16405b6 
* Missing configuration change, TODO alongside a PR to Kuadrant Operator

Signed-off-by: dd di cesare <didi@posteo.net>
@didierofrivia
[refactor] Delegating building descriptors to the Policy impl
d87a012 
* Extracted to `crate::policy::Policy`

Signed-off-by: dd di cesare <didi@posteo.net>
@didierofrivia didierofrivia mentioned this pull request Aug 8, 2024
Closed
@didierofrivia didierofrivia self-assigned this Aug 8, 2024
@didierofrivia didierofrivia marked this pull request as ready for review August 8, 2024 14:34
adam-cattermole
adam-cattermole approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adam-cattermole adam-cattermole mentioned this pull request Aug 9, 2024
Merged
@didierofrivia didierofrivia mentioned this pull request Aug 12, 2024
Merged
@didierofrivia didierofrivia merged commit 6519ce5 into main Aug 13, 2024
7 checks passed
@didierofrivia didierofrivia deleted the refactoring-1-bis branch August 13, 2024 09:39
@didierofrivia didierofrivia mentioned this pull request Oct 1, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-cattermole adam-cattermole adam-cattermole approved these changes

@alexsnaps alexsnaps Awaiting requested review from alexsnaps

Assignees

@didierofrivia didierofrivia

Labels
None yet
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@didierofrivia @adam-cattermole