Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web app manifest for assistant website #3548

Closed
gregbacchus opened this issue Jul 5, 2023 · 2 comments · Fixed by #3632
Closed

Web app manifest for assistant website #3548

gregbacchus opened this issue Jul 5, 2023 · 2 comments · Fixed by #3632
Labels
feature New feature or request good first issue Good issue for project newcomers website

Comments

@gregbacchus
Copy link

I'd like to suggest that you add a web app manifest to the assistant website.

https://developer.mozilla.org/en-US/docs/Web/Manifest
https://web.dev/add-manifest/

With the correct settings ("display": "standalone"), this will enable users (using Chrome, Edge or Safari) to "Install" the assistant on mobile devices or desktop so that it appears nearly like a native app.
@camsdixon1 camsdixon1 added the feature New feature or request label Jul 5, 2023
@olliestanley olliestanley added the good first issue Good issue for project newcomers label Jul 10, 2023
@sun-jay
Copy link
Contributor

sun-jay commented Aug 4, 2023

Hey I added a manifest.json and its pretty cool. I accessed my local web server on my phone and you can basically add Open Assistant as an app on your phone (not sure if you have to sign in every time though). Opening up a pull request for my branch.

@sun-jay
Copy link
Contributor

sun-jay commented Aug 4, 2023

PR is here: #3632

@sun-jay sun-jay mentioned this issue Aug 4, 2023
Merged
@AbdBarho AbdBarho linked a pull request Aug 8, 2023 that will close this issue
Web App Manifest - Save as desktop or mobile app #3632
Merged
AbdBarho pushed a commit that referenced this issue Aug 8, 2023
@sun-jay
Web App Manifest - Save as desktop or mobile app (#3632)
9a208ea 
From issue #3548

This commit adds a manifest file that allows users to save the website
on desktop or mobile, see [this
documentation](https://developer.mozilla.org/en-US/docs/Web/Manifest).
It makes an icon that can be added to dock, mobile homescreen, etc.

Changes in this PR:
- Add a smaller logo file for certain mobile platforms
- Add manifest.json that contains logos, titles, descriptions, etc.
- Add a link to manifest.json in _document.tsx

<img width="700" alt="Screenshot 2023-08-03 at 8 23 43 PM"
src="https://github.com/LAION-AI/Open-Assistant/assets/80140457/f86946cb-62d7-42a6-a9ed-4a493b91d1da">
<img width = "300" alt ="mobile icon" src =
"https://github.com/LAION-AI/Open-Assistant/assets/80140457/8f81a8ba-3c57-4fb1-98a0-b20a37a188bd"/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request good first issue Good issue for project newcomers website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Web App Manifest - Save as desktop or mobile app
5 participants
@olliestanley @gregbacchus @andreaskoepf @camsdixon1 @sun-jay