Chat config and plugin UI/UX rework #3050
Conversation
notmd
changed the title
| model_config_name: string; | ||
| selectedPresetName: string; | ||
| custom_preset_config: SamplingParameters; | ||
| custom_presets: Array<{ name: string; config: SamplingParameters }>; |
There was a problem hiding this comment.
This will be used in the next PR when I implement #3035
|
|
||
| const CHAT_CONFIG_KEY = "CHAT_CONFIG"; | ||
| const CHAT_CONFIG_KEY = "CHAT_CONFIG_V2"; |
There was a problem hiding this comment.
I bump the cache key here
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "es5", | |||
| "target": "ESNext", | |||
There was a problem hiding this comment.
This allow to use new feature, Next doesn't use tsconfig to compile code, so there is no runtime change
There was a problem hiding this comment.
Thank you for this big refactor ♥.
Unfortunately, there are so many changes I don't believe I can review and give good feedback, so I will just approve.
Please refrain from doing PRs with 1000 line changes in the future. Probably every item on the list could be done in a different PR.
|
Ah sorry the big PR, I also plan to separate the plugin UI/UI to a different PR, but the change needs to make it work correctly with the new cache pretty overlap with the UI , so I include it in this PR too. Will try to make the up coming Prs much smaller |
|
❌ pre-commit failed. |
Also removed outdated `initialChats` since we fetch everything client side now. Desktop:  Mobile:  Currently only enabled in development since some features are still missing. Blocked by #3050
This PR addresses the following fixes and modifications: - Some plugin url-s are with text/json content_type so downloading and parsing fails. This is now fixed with content_type check + using response.text() + json.loads - Some plugins openapi specifications don't have operation-id so tool name becomes "", I now added a fallback to endpoint.path if that is the case. - Some plugins do not have the full openapi spec URL specified in their description, so parsing of it fails. This is now fixed with the detection of such cases and than merging plugins config url + openapi spec path. - If users add a bunch of plugins, there was no height or scrolling inside of a PluginChooser dropdown, this is fixed now. (will leave this out as #3050 already solves this) --------- Co-authored-by: Oliver <olivergestanley@gmail.com>
ChatConfigFormonly to avoid conditional race. Also theChatConfigFormnow have local states, we can't sync the local state if we render 2 form. I think we should apply this to theChatListBaseas wellPluginChooseUI/UXenabledplugins to the inference only, so the inference can remove the enabled check.