Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text overlapping in chat text area #3102

Merged
merged 4 commits into from
May 9, 2023
Merged

Fix text overlapping in chat text area #3102

merged 4 commits into from
May 9, 2023

Conversation

HassanTanveer
Copy link
Contributor

@HassanTanveer HassanTanveer commented May 9, 2023 •
edited
Loading

Added padding to the right of the chat text area.

Fixes #3097

image

@HassanTanveer HassanTanveer marked this pull request as ready for review May 9, 2023 00:37
@HassanTanveer HassanTanveer mentioned this pull request May 9, 2023
Closed
@olliestanley olliestanley added website UI/UX All website Components labels May 9, 2023
@echo0x22
Copy link
Contributor

echo0x22 commented May 9, 2023

Thanks! But maybe make it a bit
IMG_20230509_115738_677
closer?

@HassanTanveer
Copy link
Contributor Author

I've updated the padding. I think the difference looked exaggerated due to text-wrapping.

Now the spacing looks like this:
image

notmd
notmd approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@notmd notmd enabled auto-merge (squash) May 9, 2023 14:44
@notmd notmd disabled auto-merge May 9, 2023 14:46
@notmd notmd enabled auto-merge (squash) May 9, 2023 14:50
@notmd notmd merged commit 96cf387 into LAION-AI:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmd notmd notmd approved these changes

@AbdBarho AbdBarho Awaiting requested review from AbdBarho AbdBarho is a code owner

@yk yk Awaiting requested review from yk yk is a code owner

@andreaskoepf andreaskoepf Awaiting requested review from andreaskoepf andreaskoepf is a code owner

Assignees
No one assigned
Labels
UI/UX All website Components website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text is layered on the send button (and settings) in the chat
4 participants
@HassanTanveer @echo0x22 @notmd @olliestanley