Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next changes, remove @next/font #3124

Merged
merged 5 commits into from
May 13, 2023
Merged

next changes, remove @next/font #3124

merged 5 commits into from
May 13, 2023

Conversation

dewasahu2003
Copy link
Contributor

removed @next/font

dewasahu2003 and others added 2 commits May 10, 2023 20:26
@dewasahu2003
Merge pull request #1 from LAION-AI/main
5759db1 
merge and update fork
@dewasahu2003
@next/font to next/font
b1a9247 
removed @next/font
@github-actions
Copy link

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@github-actions
Copy link

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@andreaskoepf andreaskoepf changed the title Dewasahu2003/next changes next changes, remove @next/font May 11, 2023
@notmd
Copy link
Collaborator

notmd commented May 11, 2023

Thanks, can you fix the build?

@dewasahu2003
Copy link
Contributor Author

i ran pre-commit run --all-files in the root locally before committing , checks passed then, still getting the checks fails

  • i think the problem is related to package.lock.json

@notmd
Copy link
Collaborator

notmd commented May 11, 2023

Yeah I mean fix package-lock file.

@github-actions
Copy link

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@notmd notmd linked an issue May 13, 2023 that may be closed by this pull request
Remove @next/font #3111
Closed
@notmd notmd merged commit 1d1168d into LAION-AI:main May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmd notmd notmd approved these changes

@AbdBarho AbdBarho Awaiting requested review from AbdBarho AbdBarho is a code owner

@yk yk Awaiting requested review from yk yk is a code owner

@andreaskoepf andreaskoepf Awaiting requested review from andreaskoepf andreaskoepf is a code owner

Assignees
No one assigned
Labels
website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove @next/font
3 participants
@dewasahu2003 @notmd @andreaskoepf