Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inference backend support system prompt #3313

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Inference backend support system prompt #3313

merged 5 commits into from
Jun 7, 2023

Conversation

olliestanley
Copy link
Collaborator

No description provided.

@olliestanley olliestanley linked an issue Jun 6, 2023 that may be closed by this pull request
Support injecting system prompts in inference backend #3309
Closed
@olliestanley olliestanley enabled auto-merge (squash) June 7, 2023 20:07
andreaskoepf
andreaskoepf approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Currently only SFT-8 models (which turned out to be worse than expected) where trained with system prompt.

@olliestanley olliestanley merged commit 0fcf3e0 into main Jun 7, 2023
@olliestanley olliestanley deleted the inference-system-prompts branch June 7, 2023 20:24
@olliestanley
Copy link
Collaborator Author

OK. Currently only SFT-8 models (which turned out to be worse than expected) where trained with system prompt.

Yeah, this PR adds support in the backend but it will be disabled for now, just getting the capability in for later use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@melvinebenezer melvinebenezer Awaiting requested review from melvinebenezer melvinebenezer is a code owner

@yk yk Awaiting requested review from yk yk is a code owner

@AbdBarho AbdBarho Awaiting requested review from AbdBarho AbdBarho is a code owner

Assignees
No one assigned
Labels
inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support injecting system prompts in inference backend
2 participants
@olliestanley @andreaskoepf