Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert and update some of strings in tasks.json for the Ukrainian translation #3427

Merged

Conversation

nmeln
Copy link
Contributor

@nmeln nmeln commented Jun 14, 2023

The changes in tasks.json in #3420 removed the translation of the reply_as_assistant block. I also cannot understand some of the new translations :)

@olliestanley FIY: I didn't remove moderator_edit_explain as that seems new. But I may have missed something if there were more strings added in the blocks. Will make another PR later to sort the keys if the goal was to better follow the convention of the en translation files

Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@andreaskoepf andreaskoepf merged commit e522599 into LAION-AI:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants