Changes for orcacode experiment #3612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskoepf
requested review from
theblackcat102,
sanagno,
dvruette,
yk,
jordiclive and
shahules786
as code owners
|
Besides this I think there is a bug in this line. Config cannot be updated. I removed it from my version. Can you check that too with this PR? @andreaskoepf |
shahules786
requested changes
Jul 29, 2023
| @@ -199,45 +198,37 @@ def __getitem__(self, idx): | |||
| class DolphinMix(Dataset): | |||
| name = "dophin-mix" | |||
|
|
|||
| def __init__(self, cache_dir, num_samples=100000, max_char_len=8000, seed=42): | |||
| def __init__(self, cache_dir, num_samples: Optional[int] = None, max_char_len: int = 8000, seed: int = 42): | |||
There was a problem hiding this comment.
Isn't it better to add data_files as an argument with the default value "flan-5m..."? In this way, we can change to gpt-4 version using config if required.
`
There was a problem hiding this comment.
Can you remove the update_config function definition too since it's not used?
|
Nice, thanks. |
shahules786
approved these changes
Jul 29, 2023
x64x2
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.