Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python versions in CI. Replace point-in-polygon algorithm. #345

Merged
merged 15 commits into from
Apr 25, 2024

Conversation

fakufaku
Copy link
Collaborator

This PR updates the python versions in the build system.

  • Python 3.7 is removed due to end-of-life
  • Adds Python 3.11 and 3.12

The update revealed some bugs in the point-in-polygon algorithm used in libroom.
The old crossing based algorithm was replaced with the winding number algorithm.

  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

@fakufaku fakufaku merged commit f869ef2 into master Apr 25, 2024
37 of 38 checks passed
@fakufaku fakufaku deleted the build-update branch April 25, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant