Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to destroy Groups and Buffer data #1072

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

nselliott
Copy link
Contributor

Summary

  • This PR is a feature enhancement
  • It does the following
    • Fixes Add missing sidre group methods #674
    • Adds missing methods for destroying Groups which will also destroy Buffers if the destruction of a Group and the Views in its subtree cause the Buffer to become detached from all Views.

There already exist View destruction methods such as destroyViewsAndData that implement this destruction of Buffers for this use case. This PR extends the API so that the same thing can be executed on the entire subtree under a Group or set of Groups.

@nselliott nselliott added enhancement New feature or request Sidre Issues related to Axom's 'sidre' component labels Apr 7, 2023
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @nselliott

Copy link
Member

@agcapps agcapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Noah.

@nselliott nselliott merged commit b78f51e into develop Apr 10, 2023
@nselliott nselliott deleted the feature/nselliott/destroy-group-data branch April 10, 2023 20:04
@kennyweiss
Copy link
Member

kennyweiss commented Apr 16, 2023

Thanks for getting these functions in @nselliott !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Sidre Issues related to Axom's 'sidre' component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing sidre group methods
4 participants