Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses some odds and ends #1253

Merged
merged 10 commits into from
Jan 8, 2024
Prev Previous commit
Manually fixes some clang-tidy changes
  • Loading branch information
kennyweiss committed Jan 8, 2024
commit 030edb3532e5a43fd6642221d56052c93e6b25c4
6 changes: 2 additions & 4 deletions src/axom/mint/examples/mint_heat_equation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -363,10 +363,8 @@ const std::string help_string =
"-d INT, -dumpPeriod INT\n"
"\tThe number of cycles to wait between writing a dump file.\n";

/*!
* \brief A structure that holds the command line arguments.
*/
using Arguments = struct
/// A structure that holds the command line arguments.
struct Arguments
{
double h;
double lower_bound[2];
Expand Down
2 changes: 1 addition & 1 deletion src/axom/mint/mesh/CellTypes.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ constexpr int NUM_CELL_TYPES = static_cast<int>(CellType::NUM_CELL_TYPES);
*
* \brief Holds information associated with a given cell type.
*/
using CellInfo = struct
struct CellInfo
{
CellType cell_type; /*!< cell type, e.g. mint::QUAD, mint::HEX */
const char* name; /*!< the name associated with the cell */
Expand Down
4 changes: 2 additions & 2 deletions src/axom/sidre/tests/sidre_opaque_C.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ enum DType
_UnknownType_
};

using AA_extent = struct
struct AA_extent
{
int ilo;
int ihi;
Expand Down Expand Up @@ -60,7 +60,7 @@ int AA_get_num_pts(AA_extent* self, Centering cent)
return retval;
}

using AA_meshvar = struct
struct AA_meshvar
{
Centering cent;
DType type;
Expand Down
4 changes: 3 additions & 1 deletion src/thirdparty/tests/compiler_flag_unused_local_typedef.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@

int main()
{
using IntT = int;
// NOLINTBEGIN
typedef int IntT;
// NOLINTEND

std::cout << "I have defined type IntT, but am not using it." << std::endl;
return 0;
Expand Down