-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sina as Axom component #1378
base: develop
Are you sure you want to change the base?
Conversation
…re/bgunnar5/sina-integration
…gunnar5/sina-integration
… feature/bgunnar5/sina-integration
…gunnar5/sina-integration
…gunnar5/sina-integration
…gunnar5/sina-integration
@LLNL/axom I think all of the changes necessary are now complete for this. I'm looking into the failing tests here and I don't believe they're being caused by anything in this branch. |
…gunnar5/sina-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making my way through the PR, and this seemed like a good place to check in some comments.
So far, I've looked at the sina source code and docs, but haven't gotten to the examples or unit tests yet. Most of my comments are non-binding observations as I tried to understand the code and its relationship to existing axom functionality, e.g. don't feel compelled to make any changes.
/*! | ||
****************************************************************************** | ||
* | ||
* \file AdiakWriter.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we have some potentially similar logic in core/Annotations
See: https://github.com/LLNL/axom/blob/develop/src/axom/core/utilities/Annotations.cpp
When I looked at it for Klee, I didn't find an easy workaround. I essentially had to reverse engineer gmock's matcher macros. |
Co-authored-by: Kenny Weiss <kennyweiss@users.noreply.github.com>
…gunnar5/sina-integration
… feature/bgunnar5/sina-integration
Ok @kennyweiss I think I've made (almost) all of the changes you suggested. The only one I haven't touched yet is the Sina versioning but we should continue the discussion on that in the thread above. Other than that everything should be good to go here now (so long as all of the tests pass again). |
Summary
This PR is kind of a mirror PR for #1376 (Sina as an Axom component) that allows Axom's CI tests to run. The procedure for forked repo contributions was followed.
Note that this PR must be approved as it will be merged.
Also note that I activated the generated docs for Sina on RTD so they can be reviewed for formatting, etc. Here is the link: https://axom.readthedocs.io/en/pr-from-fork-1376/axom/sina/docs/sphinx/index.html