Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleans-up Inlet warning #654

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Cleans-up Inlet warning #654

merged 1 commit into from
Sep 21, 2021

Conversation

white238
Copy link
Member

closes #617

opened #653 to make sure this is reviewed in a more broader sense down the road.

@white238
remove member variable because it isnt used in this class but is cont…
c483b43 
…rolled by the container that holds the function
@white238 white238 added maintenance Issues related to code maintenance Inlet labels Sep 20, 2021
kennyweiss
kennyweiss approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @white238 !

@white238 white238 merged commit 77a5556 into develop Sep 21, 2021
@white238 white238 deleted the bugfix/white238/inlet_warning branch September 21, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyweiss kennyweiss kennyweiss approved these changes

@joshessman-llnl joshessman-llnl joshessman-llnl approved these changes

Assignees
No one assigned
Labels
Inlet maintenance Issues related to code maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning in clang about unused field -- inlet::Function::m_docEnabled
3 participants
@white238 @kennyweiss @joshessman-llnl