Export to EPUB improvements + bug fixes #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/hooks/useBoolean.ts
Outdated
| @@ -1,14 +1,14 @@ | |||
| import { Dispatch, SetStateAction, useCallback, useState } from 'react'; | |||
|
|
|||
| interface ReturnType { | |||
| export interface booleanHookType { | |||
There was a problem hiding this comment.
Suggested change
| export interface booleanHookType { | |
| export interface BooleanHookType { |
| epubUseCustomCSS = false, | ||
| epubUseCustomJS = false, | ||
| } = useSettings(); | ||
| const saveConfig = dispatchConfig ? true : epubLocation === ''; |
There was a problem hiding this comment.
Suggested change
| const saveConfig = dispatchConfig ? true : epubLocation === ''; | |
| const saveConfig = dispatchConfig || epubLocation === ''; |
| @@ -35,6 +35,7 @@ const CustomFileModal: React.FC<CustomCSSModalProps> = ({ | |||
| ), | |||
| placeholder = '', | |||
| }) => { | |||
| const [text, setText] = useState(customFile); | |||
There was a problem hiding this comment.
Sorry, I missed this PR before. I have fixed the TextInput's behaviour in 14ed97b so this fix shouldn't be needed anymore.
There was a problem hiding this comment.
No problem, but I can't change anything for a week now since I'm on holiday.
There was a problem hiding this comment.
I removed your version and added mine, because your version didn't support the "Not saved" text and couldn't show the file text after opening from file.
rajarsheechatterjee
approved these changes
Jul 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export to EPUB
Bugfixes
PS.: I have no idea what happend to package-lock.json