Fixes for warnings, bad defaults, and template errors. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a typical Windows plugin project, Gamma generates a couple thousand warnings for various reasons. Most of these are because of unreferenced formal parameters, but there are a handful of casting performance warnings as well.
In addition, there are bad default arguments for Echo<>. It defaults to a LoopFilter that doesn't have a damping() function, so creating one without arguments throws out some inscrutable template errors.
Finally, in the Biquad code there were two instances of explicit float usage instead of templated variables. This worked fine when using the default gam::real type, but compilation would fail when trying to use Biquad.
There are still a handful of unused function warnings remaining on Mac and Windows with typicaly build settings, but this pull request greatly reduces the number.