Add some load from pt function. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbroyar
reviewed
Mar 29, 2023
| "at_loadz_callback" | ||
| (string | ||
| @-> static_funptr Ctypes.(string @-> t @-> returning void) | ||
| @-> returning void) | ||
| end |
There was a problem hiding this comment.
I'm sorry for a probably dumb question, but you implemented two functions in C++ code: at_loadz_callback_with_device and at_loadz_callback_with_device. Why did you use only first one in ML code?
There was a problem hiding this comment.
The C++ bits are shared with the rust version of the bindings which support loading tensors directly to a device, this isn't supported on the OCaml side as it never was requested, I've still copied both C++ functions over just in case it becomes useful at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.