Addition of LayerNorm layer #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks very nice, thanks. There are some formatting failures in Travis CI, could you trying these and then we could merge the PR ? |
|
Thank you - I have updated the code formatting and it should be fine from a Travis standpoint. The AppVeyor build still fails and I am not sure why |
|
Merged, thanks for the PR (the appveyor test is flaky for now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of a layer norm layer with trainable parameters. Follows a similar design to the batch norm. Added a base functionality test as done for batch norm. Tested on few example locally and normalizes the input as expected (core logic delegated to the Tensor
f_layer_norm)