Implement binding generator in Rust #318
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR totally rewites the OCaml binding generator in Rust. Now the re-generated code passes every test on tch-rs and on large projects including rust-bert and my yolo-dl.
My motivation was to add libtorchvision bindings, but stuck in the OCaml bindgen code. I felt the pain in the hassle of codegen in strings. The rewriting will gain us the Rust's safety feature and make the project self-hosted. (I did not blame OCaml. It's a good language and I learned it recently.)
The new generated bindings should maintain the compatibility with previous code. It is ensured by tests some manual audit on rustdoc. To check if the new bindings works for your project, run
make gen
in tch-rs directory and add this to your projectCargo.toml
.BTW, I'm working on libtorchvision bindings. It will be easier if this PR can be accepted.