Use windows unicode paths to get around windows 260 char path limit. #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accidentally closed this. Anyhow while this does fix the extraction issues on windows by using the long unicode paths, it reveals a new issue. MSVC's compiler driver cl.exe fails to find certain include headers when building, which coincidentally are longer than 260 characters on my windows file system. I'm not sure if there's a flag that could be passed through I'm currently working with a much older commit (0.3.1), I've made changes that provide linux function fallbacks without looking as bad as this PR with the cfg macros. Most likely will forward port later when I've resolved the cl issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libtorchfails to extract on Windows when the project is near the 260 char windows path limit, this adds a windows check and adjusts the path. Secondly, this normalizes paths usingto_verbatim, normalizing paths should fix any issues while using a customCARGO_TARGET_DIRon Windows. This PR still needs some work.