Initial changes for iOS support #660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simlay
commented
Mar 26, 2023
| println!("Cudnn available: {}", tch::Cuda::cudnn_is_available()); | ||
| let device = tch::Device::cuda_if_available(); | ||
| //println!("Cuda available: {}", tch::Cuda::is_available()); | ||
| //println!("Cudnn available: {}", tch::Cuda::cudnn_is_available()); |
There was a problem hiding this comment.
If these two lines are uncommented, I get the following compile error:
error: linking with `cc` failed: exit status: 1
= note: Undefined symbols for architecture arm64:
"torch::cuda::is_available()", referenced from:
_atc_cuda_is_available in libtorch_sys-0d280fb35559980b.rlib(torch_api.o)
"torch::cuda::cudnn_is_available()", referenced from:
_atc_cudnn_is_available in libtorch_sys-0d280fb35559980b.rlib(torch_api.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
I'm not sure why. It doesn't happen on the macOS build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured I'd give iOS building a shot. To even get started, one must build the iOS library for PyTorch. Make sure the
TORCH_VERSIONfromtorch-sysmatches the PyTorch checkout.For
aarch64-apple-ios-simyou want to runBUILD_PYTORCH_MOBILE=1 IOS_PLATFORM=SIMULATOR IOS_ARCH=arm64 ./scripts/build_ios.sh.For
aarch64-apple-iosyou wantBUILD_PYTORCH_MOBILE=1 IOS_ARCH=arm64 ./scripts/build_ios.shIt's unclear how to get
x86_64-apple-ios(the x86-64 iOS simulator).Once you've got that built,
IPHONEOS_DEPLOYMENT_TARGET=16.1 LIBTORCH=$PWD/pytorch-checkout/build_ios/install cargo build --target aarch64-apple-ios-sim --example basicsTODO:
tch::Cuda::is_availableandtch::Cuda::cudnn_is_availableresult in unknown symbols when linkingException raised from findSchemaOrThrow at /Users/simlay/projects/torch-sys-source/pytorch/aten/src/ATen/core/dispatch/Dispatcher.cpp:131aarch64-apple-ios-sim, I get a pretty unique linking error that's unrelated to this PR:Work around is to build for host and then build for cross compiler target.
Here's the runtime error I'm seeing when I run the basics example in the iOS simulator: