Fix libgomp linking #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
mwilliammyers
pushed a commit
to mwilliammyers/tch-rs
that referenced
this pull request
Sep 3, 2019
senokay
pushed a commit
to senokay/tch-rs
that referenced
this pull request
Apr 12, 2024
This workaround originates from LaurentMazare#99. This was meant to solve LaurentMazare#95, which was ultimately found to be caused by an incorrect shared library name. In fact the current name of "tch-rs" is a result of the subsequent renaming proposed by LaurentMazare#97, but the original PR was ultimately closed in favor of the upstream fix instead. As noted in LaurentMazare#355, libtorch never actually depends on the system libgomp because it bundles its own version with an already mangled SONAME. There is a symlink to the unmangled name as well, but that seems only a compatibility measure for other libraries. Torch-sys doesn't require any other library, so `-lgomp` can be safely removed.
senokay
pushed a commit
to senokay/tch-rs
that referenced
this pull request
Apr 12, 2024
This workaround originates from LaurentMazare#99. This was meant to solve LaurentMazare#95, which was ultimately found to be caused by an incorrect shared library name. In fact the current name of "tch-rs" is a result of the subsequent renaming proposed by LaurentMazare#97, but the original PR was ultimately closed in favor of the upstream fix instead. As noted in LaurentMazare#355, libtorch never actually depends on the system libgomp because it bundles its own version with an already mangled SONAME. There is a symlink to the unmangled name as well, but that seems only a compatibility measure for other libraries. Torch-sys doesn't require any other library, so `-lgomp` can be safely removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95.