Create Pull Request #1627
Closed
Create Pull Request #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validcube
commented
Dec 5, 2023
| pull_request: | ||
|
|
||
| jobs: | ||
| optimize-auto-merge: |
There was a problem hiding this comment.
Suggested change
| optimize-auto-merge: | |
| merge-optimize-svg: |
| jobs: | ||
| optimize-auto-merge: | ||
| runs-on: ubuntu-latest | ||
| if: github.event.pull_request.title == 'Optimize SVG(s)' |
There was a problem hiding this comment.
Checking only for the title is not ideal
See https://github.com/LawnchairLauncher/lawnchair/blob/13-dev/.github/workflows/ci.yml#L109-L119 for a better implementation
| PR_URL: ${{ github.event.pull_request.html_url }} | ||
| run: | | ||
| gh pr comment $PR_URL --body "No issues found, auto-merging the pull request." | ||
| gh pr merge $PR_URL --auto --squash --delete-branch |
There was a problem hiding this comment.
Might be a problem, because we would need to let it run a bit for the required check to complete then we can merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a Pull Request instead of pushing directly to repository (See relevant rule: GH006).
Fixes #1626
Type of change
✅ Bug fix (non-breaking change which fixes an issue)
❌ General change (non-breaking change that doesn't fit the above categories, such as copyediting)