Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for Pokémon TCG Live #1808

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

service-paradis
Copy link
Contributor

Description

Add icon for Pokémon TCG Live (https://play.google.com/store/apps/details?id=com.pokemon.pokemontcgl&hl=en_US)

To keep things simple, I only kept a single card from the original icon (the right one). I think it is recognizable enough while keeping it minimal like the other icons in this package.

Icons addition information

Added

Pokémon TCG Live (com.pokemon.pokemontcgl)

Contributor's checklist

  • I made the icons following the Lawnicons Guidelines (upd. Jan 2024) and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Feb 2, 2024
@x9136
Copy link
Collaborator

x9136 commented Feb 11, 2024

There is an unforced imbalance due to the difference in the stroke width of the card and the poke ball. To fix it, just widen the card a little and apply the 10px stroke to the poke ball.
Screenshot 2024-02-11 at 12 34 54

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Feb 11, 2024
@service-paradis
Copy link
Contributor Author

There is an unforced imbalance due to the difference in the stroke width of the card and the poke ball. To fix it, just widen the card a little and apply the 10px stroke to the poke ball.

Something like this?

@x9136
Copy link
Collaborator

x9136 commented Feb 12, 2024

Something like this?

Yes, except the stroke width is wrong.
Screenshot 2024-02-12 at 16 53 57

@service-paradis
Copy link
Contributor Author

Yes, sorry, I saw it just after I commented! Should be better now!

@x9136 x9136 merged commit 7f2d116 into LawnchairLauncher:develop Feb 12, 2024
3 of 4 checks passed
@service-paradis service-paradis deleted the add-pokemon-tcg branch February 12, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants