Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 7, Linked 1 #2377

Merged
merged 33 commits into from
Oct 12, 2024
Merged

Added 7, Linked 1 #2377

merged 33 commits into from
Oct 12, 2024

Conversation

Ahmed-Khalifa
Copy link
Contributor

Added

  • Elite Hospital (ats.ksa.elite.patient/com.ats.hospital.presenter.ui.activities.SplashActivity)
  • Gate.io (com.gateio.gateio/com.gateio.biz.main.splash.SplashActivity)
  • meem KSA (com.veripark.GIB/com.veripark.GIB.meemKSA)
  • القرآن الكريم ~~ MP3 Quran (my.smartech.mp3quran/my.smartech.mp3quran.ui.SplashActivity)
  • مرسول ~~ Mrsool (com.mrsool/com.mrsool.SplashActivity)
  • MyUS (com.myus.app/com.myus.app.MainActivity)
  • نينجا ~~ Ninja (com.ananinja.lava/com.ananinja.MainActivity)

Linked

  • ماكس فاشون ~~ Max Fashion (linked com.landmarkgroup.maxstores/com.landmarkgroupreactapps.SplashActivity to @drawable/max_fashion)

Ahmed-Khalifa and others added 22 commits September 16, 2024 08:48
Reduced the size of 3 icons from 50KB to ~2KB.
almanea.svg
hungerstation.svg
mada_pay.svg
* 150X Duplicate Remover Pro (`com.nutuvamapp.onefivexduplicatexapp/com.nutuvamapp.onefivexduplicatexapp.activity.SplashActivity`)
* AlDawaa Pharmacies (`com.kr.aldawaa/com.kr.aldawaa.view.SplashActivity`)
* مطاعم الرومانسية (`com.tech_world.romansia/com.tech_world.romansia.ui.splash.SplashActivity`)
* AlinmaPay E Wallet (`com.alinma.pay.consumer/com.alinma.pay.consumer.MainActivity`)
* barq (`sa.com.barraq/com.globalfinancingsolutions.ui.splash.SplashActivity`)
* BCare (`com.app.bcare/com.nqdi.app.MainActivity`)
* Core | Crypto Wallet and NFTs (`com.avaxwallet/com.avaxwallet.MainActivity`)
Changed the stroke width to 10px for alinmapay.svg
@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Sep 26, 2024
Copy link
Contributor Author

@Ahmed-Khalifa Ahmed-Khalifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly review the pull request.
After the review, I will hard reset the repo to match upstream branch.

@x9136
Copy link
Collaborator

x9136 commented Oct 1, 2024

Kindly review the pull request.

At the moment, there is no one to do a review. If you plan to make new icons, then the wait may take months. Therefore, if you are waiting for this and it is a burden, then it is better not to wait.

Your PR cannot be accepted as it is, because half of the icons are made incorrectly. Correctly made icons: mp3quran.svg, mrsool.svg, ninja.svg.

Copy link
Contributor Author

@Ahmed-Khalifa Ahmed-Khalifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified the icons that are not correct, this time I hope they meet the requirements.

@x9136
Copy link
Collaborator

x9136 commented Oct 12, 2024

I have taken into account the Lawnicons guidelines for you. In case of creating new icons for Lawnicons, I suggest you compare and analyze the latest changes.

@x9136 x9136 merged commit b87bced into LawnchairLauncher:develop Oct 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants