Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add PR view #21

Closed
Layla-P opened this issue Oct 1, 2020 · 5 comments
Closed

Feature: Add PR view #21

Layla-P opened this issue Oct 1, 2020 · 5 comments
Assignees

Comments

@Layla-P
Copy link
Owner

Layla-P commented Oct 1, 2020

** Description: **
Use the existing add.cshtml and add method on the Homecontroller to log a PR

** Steps: **

Fields to capture

Username
Owner
Repository
PR number
PR URL

We have a DTO prepared for this:
https://github.com/Layla-P/HacktoberfestProject/blob/dev/HacktoberfestProject.Web/Models/DTOs/User.cs
The username will be captured from the HttpContext so no need to have a field for it.

In the Add Method on the Controller, we will use the TableService to save the new PR

@NapalmCodes
Copy link
Contributor

I'll take this.

@rickvdbosch
Copy link
Collaborator

This one is closed, right? PR #24 closes this.

@NapalmCodes
Copy link
Contributor

@Layla-P had review feedback. I implemented some but had some questions about other points that were raised in that original PR.

@NapalmCodes
Copy link
Contributor

@Layla-P do you mind looking at the remaining comments on #24
I think there is one there for @CrypticEngima too

@CodeItQuick
Copy link

Hello - If you add the text: "Fix #21 " to the relevant PR description it will add it to that issues discussion and close the issue when complete

Looks like it already got merged as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants