[SUPPORT] remove unnecessary check on tx networkInfo (#4020)

.changeset/thirty-pumas-sleep.md

@@ -0,0 +1,7 @@
+---
+"ledger-live-desktop": patch
+"live-mobile": patch
+"@ledgerhq/live-common": patch
+---
+
+remove unnecessary check on tx networkInfo

apps/ledger-live-desktop/src/renderer/screens/exchange/Swap2/Form/FeesDrawer/index.tsx

@@ -52,7 +52,7 @@ export default function FeesDrawer({
       />
       <DrawerTitle i18nKey="swap2.form.details.label.fees" />
       <Box mt={3} flow={4} mx={3}>
-        {transaction && "networkInfo" in transaction && transaction.networkInfo && mainAccount && (
+        {transaction && mainAccount && (
           <SendAmountFields
             account={mainAccount as Account}
             parentAccount={parentAccount}

apps/ledger-live-desktop/src/renderer/screens/exchange/Swap2/Form/FormSummary/SectionFees.tsx

@@ -78,14 +78,7 @@ const SectionFees = ({
   const family = mainFromAccount?.currency.family;
   const sendAmountSpecific = account && family && getLLDCoinFamily(family)?.sendAmountFields;
   const canEdit =
-    hasRates &&
-    showSummaryValue &&
-    transaction &&
-    "networkInfo" in transaction &&
-    transaction.networkInfo &&
-    account &&
-    family &&
-    sendAmountSpecific;
+    hasRates && showSummaryValue && transaction && account && family && sendAmountSpecific;
   const swapDefaultTrack = useGetSwapTrackingProperties();
   const StrategyIcon = useMemo(
     () =>

apps/ledger-live-mobile/src/components/SendRowsFee.tsx

@@ -2,7 +2,6 @@ import React from "react";
 import type { Account, AccountLike } from "@ledgerhq/types-live";
 import { getMainAccount } from "@ledgerhq/live-common/account/index";
 import type { Transaction, TransactionStatus } from "@ledgerhq/live-common/generated/types";
-import type { Transaction as BitcoinTransaction } from "@ledgerhq/live-common/families/bitcoin/types";
 import { CompositeScreenProps } from "@react-navigation/native";
 
 import perFamily from "../generated/SendRowsFee";
@@ -40,8 +39,7 @@ export default ({
   // eslint-disable-next-line no-prototype-builtins
   if (perFamily.hasOwnProperty(mainAccount.currency.family)) {
     const C = perFamily[mainAccount.currency.family as keyof typeof perFamily];
-    // FIXME: looks like a hack, need to find how to handle networkInfo properly
-    return (transaction as BitcoinTransaction)?.networkInfo ? (
+    return (
       <C
         {...props}
         setTransaction={setTransaction}
@@ -51,7 +49,7 @@ export default ({
         navigation={navigation}
         route={route}
       />
-    ) : null;
+    );
   }
 
   return null;

libs/ledger-live-common/src/families/solana/js-prepareTransaction.ts

@@ -110,9 +110,6 @@ const prepareTransaction = async (
     model,
   };
 
-  // LLM requires this field to be truthy to show fees
-  (patch as any).networkInfo = true;
-
   return defaultUpdateTransaction(tx, patch);
 };