Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] : Improve Market for Backend #7363

Merged
merged 3 commits into from
Jul 22, 2024
Merged

[FEAT] : Improve Market for Backend #7363

merged 3 commits into from
Jul 22, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Discussed in
https://ledgerhq.atlassian.net/wiki/spaces/BE/pages/4867096580/2024-07-18+CVS+freshness+markets+traffic+analysis

Improvements in this PR :

  • Debounced search in LLD
  • Uppercase counterCurrency in LLM/LLD
  • lowercase search in LLM/LLD
  • 2 characters are needed now to trigger search
  • sort ids when favorite filter in On

What's next ?

  • LLM pagination fix
  • Discrepancy between listing page and coin page

DEMO

Screen.Recording.2024-07-18.at.16.17.10.mov
Screen.Recording.2024-07-18.at.16.34.54.mov

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner July 18, 2024 14:51
@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 0:12am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 0:12am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 0:12am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 0:12am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 0:12am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common labels Jul 18, 2024
@mcayuelas-ledger
Copy link
Contributor Author

mcayuelas-ledger commented Jul 19, 2024 •
edited by live-github-bot bot
Loading

@mcayuelas-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@mcayuelas-ledger
Copy link
Contributor Author

mcayuelas-ledger commented Jul 22, 2024 •
edited by live-github-bot bot
Loading

@mcayuelas-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@mcayuelas-ledger
Copy link
Contributor Author

mcayuelas-ledger commented Jul 22, 2024 •
edited by live-github-bot bot
Loading

@mcayuelas-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@mcayuelas-ledger mcayuelas-ledger merged commit 3164745 into develop Jul 22, 2024
71 of 78 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the feat/improve-market branch July 22, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasWerey LucasWerey LucasWerey approved these changes

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcayuelas-ledger @LucasWerey