Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(walletsync): enhance the websocket notifications hook for watch loop #7498

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

gre
Copy link
Contributor

@gre gre commented Aug 2, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • watch loop

📝 Description

We can test on the web tools, the websocket mode is disabled by default

Capture d’écran 2024-08-02 à 11 21 11

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@gre gre requested a review from a team as a code owner August 2, 2024 09:33
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 9:33am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Aug 2, 2024 9:33am
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 2, 2024 9:33am
native-ui-storybook ⬜️ Ignored (Inspect) Aug 2, 2024 9:33am
react-ui-storybook ⬜️ Ignored (Inspect) Aug 2, 2024 9:33am

@gre
Copy link
Contributor Author

gre commented Aug 2, 2024

@gre

Generating screenshots: workflow ended

Jobs status:
❌ - generate-screenshots-linux

@gre gre merged commit 7193e79 into develop Aug 2, 2024
51 of 61 checks passed
@gre gre deleted the walletsync/watchloop-websocket-evo branch August 2, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants