Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA-206][Playwright] Increase maxFailures in CI #7885

Merged

Conversation

abdurrahman-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • Desktop UI E2E Tests

πŸ“ Description

Given getAppAndVersion and Network error occurs more often we need to increase maxFailure to prevent quick stop of tests.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 24, 2024 3:00pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 24, 2024 3:00pm
native-ui-storybook ⬜️ Ignored (Inspect) Sep 24, 2024 3:00pm
react-ui-storybook ⬜️ Ignored (Inspect) Sep 24, 2024 3:00pm
web-tools ⬜️ Ignored (Inspect) Sep 24, 2024 3:00pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 24, 2024
@abdurrahman-ledger abdurrahman-ledger merged commit ec06a5c into develop Sep 24, 2024
47 of 48 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/qaa_206_playwright_increase_maxFailures branch September 24, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants