Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(lld): rework coin control UI #8047

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Oct 8, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Rework of the UI of the coin Control under newArch behind ordinals FF

πŸ“ Description

Rework of the coin control UI using ordinals assets from simplehash

  • little changes on the modal component to be able to test id with jest
  • ResizeObserver mocked in jest to avoid error with modals

this is the first PR another one will come to add simplehash to the coinControl and display assets. Currently it's not like the Figma because we don't have the correct components but it's close

There is some TS ignore that already exist so I didn't change that because it's more about BTC implem

Screen.Recording.2024-10-09.at.23.39.50.mov
image

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Oct 9, 2024 4:09pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 4:09pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 4:09pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 4:09pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 4:09pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant