Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incremental_save fixes #343

Merged
merged 5 commits into from
May 31, 2023
Merged

incremental_save fixes #343

merged 5 commits into from
May 31, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 30, 2023 •
edited
Loading

See comments

carmocca
carmocca commented May 30, 2023
View reviewed changes
scripts/convert_hf_checkpoint.py Show resolved Hide resolved
scripts/convert_hf_checkpoint.py Outdated Show resolved Hide resolved
lit_llama/utils.py Show resolved Hide resolved
@carmocca carmocca marked this pull request as ready for review May 30, 2023 18:51
@carmocca carmocca mentioned this pull request May 30, 2023
Merged
t-vi
t-vi approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments but looks great. Thank you! (Not that my review counts. :) )

awaelchli
awaelchli approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if good with @t-vi

@carmocca carmocca enabled auto-merge (squash) May 31, 2023 14:05
@carmocca carmocca merged commit 7278fc6 into main May 31, 2023
@carmocca carmocca deleted the carmocca/incremental-save-fixes branch May 31, 2023 14:12
@carmocca carmocca self-assigned this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@awaelchli awaelchli awaelchli approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees

@carmocca carmocca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carmocca @awaelchli @t-vi