V0.1.x #651
V0.1.x #651
Conversation
… have a built version and is a hassle to set up.
…ot to speed it up (need something to trigger a run).
…nores for build folder
| "pip install pandas scikit-learn", capture=False, cd=str(tmp_path) | ||
| ) | ||
| os.chdir(str(tmp_path)) | ||
|
|
||
| virtualenv.run( | ||
| "python sliced_housing_multiple_script_dag.py", | ||
| capture=False, | ||
| # Run in current root lineapy so that relative paths are accurate | ||
| cd=str(tmp_path), | ||
| ) | ||
| subprocess.check_call(["python", "sliced_housing_multiple_script_dag.py"]) |
There was a problem hiding this comment.
getting rid of virtual env speeds up the tests from 100s to about 2 seconds. (Needed some python file change to trigger workflows in prev versions. not removing it since its a positive change)
There was a problem hiding this comment.
Just to make sure, are we intentionally retaining virtualenv input arg in the function?
| branches: | ||
| - "v[0-9]+.[0-9]+.x" | ||
| tags: | ||
| - "v[0-9]+.[0-9]+.[0-9]+" |
There was a problem hiding this comment.
can remove this if pushing tag triggers two pipelines.
There was a problem hiding this comment.
Ok, leaving this conv open for us to check if this is the case.
There was a problem hiding this comment.
I tested adding a tag. it runs it once for push only. There is no link between a publish and test though so it will be up to us to check stuff before releasing. If it creates a problem we can look into making this dependent on pytest output.
Description
Publish had a few issues. this PR should fix those and make the branch v0.1.x auto-deployable when tagged.
Fixes N/A
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
pipeline runs.