Argo Pipeline Integration #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycui97
reviewed
Dec 20, 2022
andycui97
reviewed
Dec 20, 2022
andycui97
reviewed
Dec 20, 2022
andycui97
reviewed
Dec 20, 2022
andycui97
reviewed
Dec 20, 2022
andycui97
reviewed
Dec 20, 2022
andycui97
reviewed
Dec 20, 2022
andycui97
reviewed
Dec 20, 2022
andycui97
reviewed
Dec 20, 2022
andycui97
reviewed
Dec 20, 2022
| @@ -175,7 +175,7 @@ def get_rendered_task_definitions( | |||
| loading_blocks=loading_blocks, | |||
| pre_call_block="", | |||
| call_block=task_def.call_block, | |||
| post_call_block="", | |||
| post_call_block=task_def.post_call_block, | |||
There was a problem hiding this comment.
same thing for pre_call_block makes sense?
There was a problem hiding this comment.
also not sure how jinja tackles [None]. Does it render as the string "None" or skips it? if its the former, we should use task_def.post_call_block or "" here.
lineapy/plugins/jinja_templates/task/localpickle/task_local_pickle_ser.jinja
Show resolved
Hide resolved
andycui97
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
AWWW yea
Thanks @lazargugleta for the patience in seeing this one through. Really appreciate it!
|
@andycui97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_module.pyis generated in the same manner as Airflow's so it remained_requirements.txtas well_dagfile provides an execution file to submit workflows to argo directly using hera-workflows.It is generated based on the argo_dag.jinja
Since python function is a unit of execution it stays pretty Airflow-ish alike.
It defines a WorkflowService, either parameterized by the user or given default parameters,
which is submitted along the Workflow instance.
Tasks and dependencies are generated in a different pattern but utilized the same
methods already providing the tasks and tasks definitions.
The service account token is searched for and appended to the WorkflowService as well.
With the command
python3 {pipeline_name}_dag.pythe workflow is directly submitted to the current argo environment._Dockerfile is fine
Current issues
Type of change
How Has This Been Tested?